Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIG Release charter #2919

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

justaugustus
Copy link
Member

Moved over from kubernetes/sig-release#348.
This charter has already been approved by @jdumars @calebamiles @tpepper and @timothysc.

(Assigning Aaron for final Steering approval)
/assign @spiffxp

Signed-off-by: Stephen Augustus foo@agst.us

Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Nov 8, 2018
@justaugustus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
@calebamiles
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO there are details missing. We can merge and iterate, but I left comments to explain where I think we need to iterate.

- SIG Release Members may override the majority decision of SIG Chairs by a supermajority (60%)

Additional requirements:
- KEP must establish subproject chairs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/chairs/owners

- Code branches
- Binary artifacts
- Release notes
- Continually improving release and development processes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still talking about Kubernetes releases here, or have we switched gears to releases of all Kubernetes subprojects?

- Defining and staffing release roles to manage the resolution of release blocking criteria
- Defining and driving development processes (e.g. merge queues, cherrypicks) and release processes
(e.g. burndown meetings, cutting beta releases) with the intent of meeting the release schedule
- Managing the creation of release specific artifacts, including:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a bit tangled up with SIG Architecture if they are the owners of "what is Kubernetes" but... which artifacts? Or put another way, which subprojects are in-scope vs. out-of-scope?

Maybe today's answer is "everything in k/k"? There are specific subprojects that live in there that already are (client-go) or may soon be (kubeadm) released on a different cadence. We also want to consider what this looks like with things like out-of-tree cloud provider and cluster api provider subprojects.

- Serve as a tightly integrated partner with other SIGs to empower SIGs to integrate their repositories into the release process

### In scope

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically I would expect to see Code and Binaries enumerated here. Going by sigs.yaml you apparently own hyperkube, anago, and docs for the release process.

  • Do you own package definitions that would be used to build .deb's, .rpm's or other packages, or are those considered downstream?
  • Do you own any of the files involved in building kubernetes? Things like k/k/build/ or k/k's Makefiles?
  • Do you own any jobs related to continuously building kubernetes, or are you solely responsible for manually produced builds?

- All SIG Release top-level subproject OWNERS files
- All documented former Release Team members holding Lead roles e.g., Enhancements Lead, Patch Release Team

Subproject `approvers` and incoming Release Team Leads should ensure that new members are added to the `sig-release` GitHub team.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subproject owners

- Facilitating release retrospectives
- Collaborating with downstream communities which build artifacts from Kubernetes releases

### Out of scope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, I think you're missing explicit details of which repos or subprojects you don't support. For example I doubt any repo in kubernetes-csi or kubernetes-client falls under your purview today

@spiffxp
Copy link
Member

spiffxp commented Nov 9, 2018

/lgtm
@timothysc already /lgtm'ed back in kubernetes/sig-release#348
/hold
If you'd rather address details here go for it, otherwise feel free to remove the /hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@justaugustus
Copy link
Member Author

@spiffxp -- Thanks for your review! I'm going to opt to merge and iterate here, as I think everything will be better defined once we work through the KEPs for the individual subprojects. We'll take everything you mentioned as AIs.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6fb5d42 into kubernetes:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants